refactor(transaction-controller): remove existing transaction support#8256
Open
matthewwalsh0 wants to merge 2 commits intomainfrom
Open
refactor(transaction-controller): remove existing transaction support#8256matthewwalsh0 wants to merge 2 commits intomainfrom
matthewwalsh0 wants to merge 2 commits intomainfrom
Conversation
50dc961 to
1c4ed00
Compare
1c4ed00 to
81ac976
Compare
…and AddTransactionOptions
1e4b137 to
fcd3732
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Removes legacy existing transaction deduplication logic from the transaction controller. Previously,
addTransaction,stopTransaction, andspeedUpTransactionwould look up transactions byactionIdand skip creating new ones if a match was found. This is no longer needed and adds unnecessary complexity.actionIdis still persisted on transaction metadata for state consistency.Note
Medium Risk
Changes core transaction lifecycle behavior so repeated calls with the same
actionIdwill now create additional transactions (including cancel/speedup), which could surface duplicate approvals or retries if any callers relied on implicit deduping.Overview
Removes legacy
actionId-based “existing transaction” support across transaction lifecycle methods.addTransaction,stopTransaction, andspeedUpTransactionno longer search state for a matchingactionIdto skip creating a new transaction, and the private#getTransactionWithActionIdhelper plus related tests are removed.actionIdremains persisted onTransactionMeta/AddTransactionOptionsbut is now documented as deprecated for deduplication only (state consistency), with corresponding docstring updates and a changelog entry.Written by Cursor Bugbot for commit fcd3732. This will update automatically on new commits. Configure here.