Skip to content

refactor(transaction-controller): remove existing transaction support#8256

Open
matthewwalsh0 wants to merge 2 commits intomainfrom
feat/remove-transaction-meta
Open

refactor(transaction-controller): remove existing transaction support#8256
matthewwalsh0 wants to merge 2 commits intomainfrom
feat/remove-transaction-meta

Conversation

@matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Mar 19, 2026

Explanation

Removes legacy existing transaction deduplication logic from the transaction controller. Previously, addTransaction, stopTransaction, and speedUpTransaction would look up transactions by actionId and skip creating new ones if a match was found. This is no longer needed and adds unnecessary complexity.

actionId is still persisted on transaction metadata for state consistency.


Note

Medium Risk
Changes core transaction lifecycle behavior so repeated calls with the same actionId will now create additional transactions (including cancel/speedup), which could surface duplicate approvals or retries if any callers relied on implicit deduping.

Overview
Removes legacy actionId-based “existing transaction” support across transaction lifecycle methods. addTransaction, stopTransaction, and speedUpTransaction no longer search state for a matching actionId to skip creating a new transaction, and the private #getTransactionWithActionId helper plus related tests are removed.

actionId remains persisted on TransactionMeta/AddTransactionOptions but is now documented as deprecated for deduplication only (state consistency), with corresponding docstring updates and a changelog entry.

Written by Cursor Bugbot for commit fcd3732. This will update automatically on new commits. Configure here.

@matthewwalsh0 matthewwalsh0 force-pushed the feat/remove-transaction-meta branch from 50dc961 to 1c4ed00 Compare March 20, 2026 21:28
@matthewwalsh0 matthewwalsh0 force-pushed the feat/remove-transaction-meta branch from 1c4ed00 to 81ac976 Compare March 22, 2026 13:50
@matthewwalsh0 matthewwalsh0 changed the title refactor(transaction-controller): remove existing transaction deduplication logic refactor(transaction-controller): remove existing transaction support Mar 22, 2026
@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review March 22, 2026 14:32
@matthewwalsh0 matthewwalsh0 requested review from a team as code owners March 22, 2026 14:32
@matthewwalsh0 matthewwalsh0 force-pushed the feat/remove-transaction-meta branch from 1e4b137 to fcd3732 Compare March 22, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant