Feat/add stellar bridge controller#8625
Open
Julink-eth wants to merge 9 commits into
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0b037a5. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Explanation
Adds Stellar support to
@metamask/bridge-controller, following the existing non-EVM patterns for Solana, Bitcoin, and Tron. This includes Stellar chain/native asset constants, CAIP formatting, default token metadata, quote validation, non-EVM fee handling via snapcomputeFee, and targeted test coverage.Also aligns Stellar asset formatting with the Bridge API contract:
stellar:pubnet/slip44:148stellar:pubnet/asset:CODE-ISSUERstellar:pubnet/sep41:C...References
Checklist
Note
Medium Risk
Adds a new non-EVM chain path (Stellar) across chain-id/asset formatting, validation, and snap-based fee computation; regressions could impact quote requests or fee display for non-EVM chains. Changes are mostly additive with tests, limiting blast radius but touching shared chain-id utilities.
Overview
Adds Stellar network support to
@metamask/bridge-controller, including a newChainId.STELLAR,XlmScope.Pubnetbeing treated as an allowed bridge chain, and default native token metadata for XLM (decimals/slip44 mapping).Extends shared utilities to recognize Stellar via
isStellarChainId, treat it as non-EVM inisNonEvmChainId, and format Stellar chain IDs/asset IDs incaip-formatters(nativestellar:pubnet/slip44:148, classicasset:CODE-ISSUER, and Sorobansep41:C…).Updates quote request validation to require
destWalletAddresswhen bridging to/from Stellar, exportsisStellarChainId, and adds targeted tests (including verifying Stellar quotes getnonEvmFeesInNativevia snapcomputeFeecalls).Reviewed by Cursor Bugbot for commit d8f0ece. Bugbot is set up for automated code reviews on this repo. Configure here.