Generate new packages with not only MIT, but also Apache 2.0#8815
Merged
Conversation
4 tasks
Member
|
Should we have the third LICENSE file as well, pointing at those two? e.g. https://github.com/MetaMask/core/blob/main/packages/wallet/LICENSE |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7026b09. Configure here.
mcmire
commented
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Explanation
The long-standing recommendation from Legal is that use both MIT and Apache 2.0 for our libraries, not just MIT. We had meant to change this in
corea while back but kept forgetting. This commit updates the template that thecreate-packagetool uses to generate new packages so that it includes both of these licenses.This also fixes the MIT license as it was missing a final line.
Manual testing
yarn create-package --name foo --description "The foo package"packages/foo, you should seeLICENSE.MITandLICENSE.APACHE2packages/foo/package.json,licenseshould be "(MIT OR Apache-2.0)"References
Checklist
Note
Low Risk
Low risk: template-only licensing text changes that affect newly generated packages, with no runtime or build logic modifications.
Overview
Updates the
create-packagepackage template to generate dual-licensed packages.Replaces the single MIT
LICENSEwith a short dual-license notice and adds fullLICENSE.MITandLICENSE.APACHE2files, and updates the templatepackage.jsonlicensefield to(MIT OR Apache-2.0).Reviewed by Cursor Bugbot for commit dd28b16. Bugbot is set up for automated code reviews on this repo. Configure here.