Skip to content

fix(assets-controller): fetch metadata for balances missing assetsInfo#9547

Open
salimtb wants to merge 5 commits into
mainfrom
fix/assets-controller-heal-balance-metadata
Open

fix(assets-controller): fetch metadata for balances missing assetsInfo#9547
salimtb wants to merge 5 commits into
mainfrom
fix/assets-controller-heal-balance-metadata

Conversation

@salimtb

@salimtb salimtb commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

DetectionMiddleware only queues brand-new assets, so already-tracked balances without metadata never got enriched and stayed invisible in clients.

Explanation

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Scoped enrichment and network-list changes in the assets pipeline; no auth or breaking API changes, with regression coverage for the balance-only metadata path.

Overview
Token metadata enrichment now covers tokens that already appear in assetsBalance but lack assetsInfo (or an image), not only assets queued via detectedAssets. That closes a gap where tracked balances could stay invisible in clients because detection middleware only queues brand-new assets.

TokenDataSource middleware walks response.assetsBalance with the same skip rules as detection (existing image in response/state, staking contracts) and batches those asset IDs into the existing Tokens API v3 fetch.

Robinhood Chain (4663 / 0x1237) is added to SUPPORTED_NETWORKS_ACCOUNTS_API_V4 in @metamask/assets-controllers so balances and token detection use the Accounts API instead of RPC-only paths.

Reviewed by Cursor Bugbot for commit f7e9195. Bugbot is set up for automated code reviews on this repo. Configure here.

salimtb added 5 commits July 18, 2026 14:20
DetectionMiddleware only queues brand-new assets, so already-tracked
balances without metadata never got enriched and stayed invisible in clients.
@salimtb
salimtb marked this pull request as ready for review July 18, 2026 12:52
@salimtb
salimtb requested review from a team as code owners July 18, 2026 12:52
@salimtb
salimtb deployed to default-branch July 18, 2026 12:52 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant