fix: hide unlisted secondary project chips across question page & notebook#4895
Draft
SylvainChevalier wants to merge 1 commit into
Draft
fix: hide unlisted secondary project chips across question page & notebook#4895SylvainChevalier wants to merge 1 commit into
SylvainChevalier wants to merge 1 commit into
Conversation
…nfo tab and notebook The previous fix only covered the sidebar chip list. The header meta row, the Question Info tab, and the notebook reader concatenate the same project arrays and were still rendering unlisted secondary projects. Co-authored-by: Sylvain <SylvainChevalier@users.noreply.github.com>
SylvainChevalier
temporarily deployed
to
testing_env
GitHub Actions
Inactive
SylvainChevalier
temporarily deployed
to
testing_env
GitHub Actions
Inactive
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🚀 Preview EnvironmentYour preview environment is ready!
Details
ℹ️ Preview Environment InfoIsolation:
Limitations:
Cleanup:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4687
Summary
The earlier fix only filtered unlisted secondary projects in the question page sidebar. The same concatenated project list also renders in the header meta row (with a “N more” popover), the Question Info tab, and the notebook reader — so unlisted secondary projects were still visible there.
Changes
meta_row.tsx: add unlisted-visibility guard to the dedup/filter chain.question_info.tsx: add unlisted-visibility guard toallProjects.notebook_editor/index.tsx: add unlisted-visibility guard tootherProjects.In every case the default (main) project is still shown even if it’s unlisted; only secondary unlisted projects are dropped.
Generated with Claude Code