feat: 细化reason#435
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the field validation functions in rule_quanliang.py to return a ValidationResult tuple containing a boolean status and a detailed error message, replacing the previous boolean-only return values. The evaluation logic is updated to handle this new return type and format more descriptive failure reasons. The reviewer points out that these updated error messages will break existing test assertions in test/data/scibase/rule_quanliang_cases.jsonl and requests updating the test file to match the new format.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| reasons.append(f"{field}: unsupported field") | ||
| continue | ||
| if field not in normalized: | ||
| bad_fields.append(field) | ||
| reasons.append("missing field") | ||
| reasons.append(f"{field}: missing field") | ||
| continue | ||
| if FIELD_VALIDATORS[field](normalized): | ||
| validation_result = FIELD_VALIDATORS[field](normalized) | ||
| if isinstance(validation_result, tuple): | ||
| invalid, detail_reason = validation_result | ||
| else: | ||
| invalid = bool(validation_result) | ||
| detail_reason = "failed field validation" | ||
| if invalid: | ||
| bad_fields.append(field) | ||
| reasons.append(f"{field} invalid") | ||
| reasons.append(f"{field}: {detail_reason or 'failed field validation'}") |
There was a problem hiding this comment.
对验证原因（reason）的细化（如在原因前加上字段名并提供更详细的错误信息）是一个很好的改进。然而，请注意，这一修改会破坏 test/data/scibase/rule_quanliang_cases.jsonl 中现有的测试用例，因为这些用例对具体的错误原因字符串进行了精确断言（例如 "missing field"、"unsupported field" 和 "doi invalid"）。
请务必同步更新 test/data/scibase/rule_quanliang_cases.jsonl 中的 expected_reasons，以匹配新的详细原因格式，确保测试套件能够顺利通过。
1 participant
No description provided.