Compatibility Update for ForgeGradle 1.0#1073
Open
zeng-github01 wants to merge 2 commits intoMinecraftForge:FG_1.0from
Open
Compatibility Update for ForgeGradle 1.0#1073zeng-github01 wants to merge 2 commits intoMinecraftForge:FG_1.0from
zeng-github01 wants to merge 2 commits intoMinecraftForge:FG_1.0from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Compatibility Update for ForgeGradle 1.0
Summary
This PR introduces critical compatibility updates for ForgeGradle 1.0. It primarily addresses the asset downloading failures caused by legacy Mojang service deprecation and upgrades the build system to a more stable Gradle version.
Changes
Reasoning
The original asset download servers used by ForgeGradle 1.0 are no longer functional, leading to "Download Failed" errors during workspace setup. By utilizing the updated Mojang API logic, the development environment for legacy Minecraft versions remains viable. Upgrading to Gradle 4.10 provides better support for modern IDEs and CI/CD pipelines.
Testing Performed
./gradlew cleanand successfully ran./gradlew setupDevWorkspace.