Skip to content

fix: Use posix path for Windows compatibility#314

Merged
stephantul merged 7 commits intomainfrom
fix-persistence-issue-on-windows
Mar 27, 2026
Merged

fix: Use posix path for Windows compatibility#314
stephantul merged 7 commits intomainfrom
fix-persistence-issue-on-windows

Conversation

@stephantul
Copy link
Contributor

Fixes #313

In #305 I refactored persistence but forgot that Windows requires a conversion to posix-path before addressing HF. We don't have good windows coverage.

@codecov
Copy link

codecov bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
model2vec/persistence/persistence.py 98.70% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stephantul stephantul requested a review from Pringled March 27, 2026 12:35
@stephantul stephantul merged commit ed9dc08 into main Mar 27, 2026
9 checks passed
@stephantul stephantul deleted the fix-persistence-issue-on-windows branch March 27, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression with 0.8.0 and Windows

1 participant