Open
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors a large part of the training logic. The base class is now much more feature complete, and takes care of everything that does not have labeled data. The classifier has become much smaller, and only takes care of data that has labels.
Here's a concise summary of the changes:
StaticModelForSimilarity. This currently only supports cosine similarity training.normalizeargument to the initializer. This controls whether the model encoding is normalized.from_pretrainedto mimic those inStaticModeland added a deprecation warning to the old argument.StaticModelPipelinenow supports projection, backed by a scikit learnMLPRegressor. This allows us to create static models with additional dense layers and put them in sklear pipelines.And maybe some other changes I forgot. Not everything is fully covered by tests, but most of it is.