Bump dependencies to resolve vulnerabilities#1
Open
corhere wants to merge 1 commit into
Open
Conversation
e4fa66b to
b5ca403
Compare
Bump most dependencies reported as vulnerable by govulncheck which have fixes available. It is unfortunately not feasible to bump buildkit to v0.28.1 to resolve CVE-2026-33747. It pulls in some other dependency bumps that are mutually incompatible with each other thanks to agressive removals of deprecated symbols in non-major releases. Signed-off-by: Cory Snider <csnider@mirantis.com>
b5ca403 to
1ccdaa6
Compare
smerkviladze
reviewed
Jul 9, 2026
| --mount=type=cache,target=/go/pkg/mod \ | ||
| --mount=type=bind,from=osxcross,src=/osxsdk,target=/xx-sdk \ | ||
| xx-go --wrap && \ | ||
| if [ "$(xx-info os)" == "darwin" ]; then export CGO_ENABLED=1; fi && \ |
Collaborator
There was a problem hiding this comment.
Could we set MACOSX_VERSION_MIN=11.0 for Darwin builds to keep CI green? That's the environment variable xx reads when computing the target triple. It must be exported before xx-go --wrap because the wrap step bakes the compiler wrapper (with the target triple embedded in its name) into Go's environment file. Setting it after the wrap step has no effect.
Suggested change
| if [ "$(xx-info os)" == "darwin" ]; then export CGO_ENABLED=1 MACOSX_VERSION_MIN=11.0; fi && \ | |
| xx-go --wrap && \ |
Collaborator
Author
There was a problem hiding this comment.
Hmm, upstream doesn't need to set that env var. I'll investigate further.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump most dependencies reported as vulnerable by govulncheck which have fixes available.
It is unfortunately not feasible to bump buildkit to v0.28.1 to resolve CVE-2026-33747. It pulls in some other dependency bumps that are mutually incompatible with each other thanks to agressive removals of deprecated symbols in non-major releases.
What I did
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did