Skip to content

Bump dependencies to resolve vulnerabilities#1

Open
corhere wants to merge 1 commit into
Mirantis:v2.40.xfrom
corhere:bump-deps-v2.40-2026-07
Open

Bump dependencies to resolve vulnerabilities#1
corhere wants to merge 1 commit into
Mirantis:v2.40.xfrom
corhere:bump-deps-v2.40-2026-07

Conversation

@corhere

@corhere corhere commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Bump most dependencies reported as vulnerable by govulncheck which have fixes available.

It is unfortunately not feasible to bump buildkit to v0.28.1 to resolve CVE-2026-33747. It pulls in some other dependency bumps that are mutually incompatible with each other thanks to agressive removals of deprecated symbols in non-major releases.

What I did

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@corhere corhere requested review from dperny and smerkviladze July 8, 2026 19:48
@corhere corhere force-pushed the bump-deps-v2.40-2026-07 branch from e4fa66b to b5ca403 Compare July 8, 2026 19:55
Bump most dependencies reported as vulnerable by govulncheck which have
fixes available.

It is unfortunately not feasible to bump buildkit to v0.28.1 to resolve
CVE-2026-33747. It pulls in some other dependency bumps that are
mutually incompatible with each other thanks to agressive removals of
deprecated symbols in non-major releases.

Signed-off-by: Cory Snider <csnider@mirantis.com>
@corhere corhere force-pushed the bump-deps-v2.40-2026-07 branch from b5ca403 to 1ccdaa6 Compare July 8, 2026 20:08
Comment thread Dockerfile
--mount=type=cache,target=/go/pkg/mod \
--mount=type=bind,from=osxcross,src=/osxsdk,target=/xx-sdk \
xx-go --wrap && \
if [ "$(xx-info os)" == "darwin" ]; then export CGO_ENABLED=1; fi && \

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we set MACOSX_VERSION_MIN=11.0 for Darwin builds to keep CI green? That's the environment variable xx reads when computing the target triple. It must be exported before xx-go --wrap because the wrap step bakes the compiler wrapper (with the target triple embedded in its name) into Go's environment file. Setting it after the wrap step has no effect.

Suggested change
if [ "$(xx-info os)" == "darwin" ]; then export CGO_ENABLED=1 MACOSX_VERSION_MIN=11.0; fi && \
xx-go --wrap && \

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, upstream doesn't need to set that env var. I'll investigate further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants