Update state visualizer and add tests#1123
Open
keveleigh wants to merge 14 commits into
Open
Conversation
…uld stay subscribed to the old interactable
…'t update the AnimationPlayableOutput
joschemd-MS
reviewed
Jun 3, 2026
Comment on lines
+383
to
+398
| if (EvaluateEffects() && interactable != null && !interactable.isSelected && !interactable.isHovered) | ||
| { | ||
| // Start asleep if nothing is happening. This prevents the Animator from | ||
| // briefly waking up and applying bind poses with 0 weights, which overwrites | ||
| // values set by other components (like theme binders). | ||
| animator.enabled = false; | ||
| playableGraph.Stop(); | ||
| enabled = false; | ||
| } | ||
| else | ||
| { | ||
| animator.enabled = true; | ||
| playableGraph.Play(); | ||
| enabled = true; | ||
| sleepTimer = keepAliveTime; | ||
| } |
There was a problem hiding this comment.
Be careful on this and make sure it's fully tested, this section has caused me much grief. There are cases where the wieghts have been changed but haven't been pushed through to the Animator before it is put to sleep thus we get quirks. I recommend considering calling playableGraph.Evaluate() again just before the sleep is enabled.
Contributor
Author
There was a problem hiding this comment.
Ah hmm...I wrote a few more tests, but I'll keep thinking on this one to make sure I've caught everything. "Good" to know it's been a troublesome spot, at least 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AnimationPlayableOutput.InteractableandAnimatoronStatefulVisualizer.