Point the setup provisioning at MobilityDB's pgtypes headers#69
Merged
estebanzimanyi merged 1 commit intoJul 22, 2026
Merged
Conversation
MobilityDB vendors the PostgreSQL 18 base headers in its `pgtypes/` library; there is no top-level `postgres/` directory. setup.py sparse-checked out `postgres` and symlinked `meos/postgres` to `_mobilitydb/postgres`, so against current master the sparse-checkout matches nothing and the symlink step aborts with `expected postgres headers at _mobilitydb/postgres`. Sparse-check out `pgtypes` and target the `meos/postgres` symlink at it. The `pgtypes/` tree carries `postgres.h` plus the same `c.h` / `access` / `utils` layout, so `#include <postgres.h>` and `#include <utils/...>` resolve as before and local catalog generation works against current MobilityDB master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup.pyprovisions the MobilityDB headers for local catalog generation by sparse-checking out a top-levelpostgres/directory and symlinkingmeos/postgresto it. MobilityDB vendors the PostgreSQL 18 base headers in itspgtypes/library instead — there is no top-levelpostgres/— so against currentmasterthe sparse-checkout matches nothing and the symlink step aborts:This sparse-checks out
pgtypes/and targets themeos/postgressymlink at it. Thepgtypes/tree carriespostgres.hplus the samec.h/access/utilslayout, so#include <postgres.h>and#include <utils/...>resolve exactly as before andpython setup.pysucceeds against current MobilityDB master.The CI catalog build is unaffected — it provisions via
provision-meos(build-libmeos), notsetup.py. This only restores the lightweight local-dev provisioning path documented inGENERATION.md.