Fix docs build: restore pg_interval_in and .js import extensions#7
Open
estebanzimanyi wants to merge 1 commit into
Open
Conversation
The track-master port (MobilityDB#6) regressed the push-triggered docs build in two ways: - The generated functions.generated.ts imports lost their `.js` extensions. The committed file carried them, but the template did not, so regenerating dropped them and typedoc/vitepress (nodenext resolution) failed with TS2835. Add the extensions to the template imports so regeneration keeps them. - pg_interval_in disappeared. It is declared in pgtypes.h, not a public meos_*.h umbrella header, so the MEOS-API catalog (run.py ingests meos/include only) never contained it; the previous in-repo extractor did. It is used by Temporal, so its loss broke the build with TS2305. Wrap it by hand in the C preamble and the TS header, forward-declaring the pgtypes symbol (resolved from libpgtypes.a at link time). Also emit the "do not edit" banner from the generator instead of storing it in the hand-edited source templates, so the templates are plainly editable source and the generated outputs still carry the marker. `npm run docs:build` passes (0 errors).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the push-triggered docs build across three changes.
.jsimport extensionsThe
functions_ts_header.ts.templateimports carry explicit.jsextensions (../runtime/meos.js,./errors.js), so the generatedfunctions.generated.tsresolves undertypedoc/vitepressnodenext module resolution.pg_interval_inpg_interval_inis declared inpgtypes.h, not a publicmeos_*.humbrella header, so the MEOS-API catalog (run.pyingestsmeos/includeonly) does not carry it.Temporaldepends on it, so it is wrapped by hand in the C preamble and the TS header, forward-declaring the pgtypes symbol (resolved fromlibpgtypes.aat link time).Banner source
The generator emits the
do not editbanner into its outputs, keeping it out of the hand-edited source templates so the templates read as plain editable source.