You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This ticket was done to make working and debugging map issues easier in dev
When running the app in dev, no data would show on any map, but it would work on production. After lots of debugging, the issue was the browserlist in development. Turbopack + SWC saw that it only needed to render for the latest browser of chrome, firefox and safari and due to this behaviour, it omitted some of the backwards compatible capabilities.
We did not get this issue in production because in the browser list we specify a broader range of browsers and due to that, these backwards compatibilities are resolved.
I did tests with webpack and it worked, meaning this is a bug with Turbopack. The solution for today is to remove the browserlist for development and default to nextjs defaults. If it ever stops working, we might switch to webpack for bundling or create a support ticket
Expected behavior:
When running next dev you should be able to see the map data
Testing tips:
Run the app locally using next dev go to any feed with a map in dev (stm or mbta) and see the elements appear on the map (routes / bounding box / etc)
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the unit tests with yarn test to make sure you didn't break anything
Add or update any needed documentation to the repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
closes #34 in preparation for #65
This ticket was done to make working and debugging map issues easier in dev
When running the app in dev, no data would show on any map, but it would work on production. After lots of debugging, the issue was the browserlist in development. Turbopack + SWC saw that it only needed to render for the latest browser of chrome, firefox and safari and due to this behaviour, it omitted some of the backwards compatible capabilities.
We did not get this issue in production because in the browser list we specify a broader range of browsers and due to that, these backwards compatibilities are resolved.
I did tests with webpack and it worked, meaning this is a bug with Turbopack. The solution for today is to remove the browserlist for development and default to nextjs defaults. If it ever stops working, we might switch to webpack for bundling or create a support ticket
Expected behavior:
When running
next devyou should be able to see the map dataTesting tips:
Run the app locally using
next devgo to any feed with a map in dev (stm or mbta) and see the elements appear on the map (routes / bounding box / etc)Please make sure these boxes are checked before submitting your pull request - thanks!
yarn testto make sure you didn't break anything