fix: prevent authentication bypass in annotation Label Studio login#510
Merged
Conversation
Add user authentication check and project existence validation to
/project/{mapping_id}/login endpoint. Previously, any unauthenticated
user could obtain Label Studio admin session cookies by calling this
endpoint, gaining full administrative access to the annotation platform.
- Require valid User header before processing login
- Validate that mapping_id corresponds to an existing non-deleted project
- Return 401 if not authenticated, 404 if project not found
- Add audit logging for successful login attempts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add user authentication check and project existence validation to /project/{mapping_id}/login endpoint. Previously, any unauthenticated user could obtain Label Studio admin session cookies by calling this endpoint, gaining full administrative access to the annotation platform.
close: #509