fix: 算子开发中，有代码注入的问题，通过在算子中写入恶意代码可导致RCE#513
Merged
Merged
Conversation
Replace create_subprocess_shell with create_subprocess_exec using argument lists to prevent command injection when executing operator tasks. Added cmd_args parameter to CommandTask/CommandScheduler for safe argument-list-based process spawning. Changes: - cmd_task_scheduler.py: Add cmd_args support to CommandTask and CommandScheduler, using create_subprocess_exec(*cmd_args) which avoids shell interpretation of metacharacters - datamate_wrapper.py: Use cmd_args list instead of shell string - data_juicer_wrapper.py: Use cmd_args list instead of shell string FCE: Code injection via operator shell commands could lead to RCE
Add Python identifier validation to prevent code injection through crafted operator names in importlib.import_module and dynamic imports. Changes: - dataset.py load_ops_module: Validate op_name and registry_content against safe identifier patterns before importlib.import_module - ops/__init__.py: Filter directory names to valid Python identifiers before dynamic import FCE: Malicious operator names could bypass registry and trigger arbitrary code execution via dynamic imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close: #511