🐛 Bugfix: Adapt frontend for k8s A2A port configuration#3271
Conversation
…f-verification" field
…ubernetes container. (#3254) [Specification Details] 1. Modify the pod naming logic to convert all non-compliant characters to -. 2. Modify test cases.
…of type 'FieldInfo' is not iterable (#3259)
…fter importing an agent. (#3258) [Specification Details] 1. The frontend does not pass `agent_id` when calling the `regenerate_name` API.
The default setting for client-side self-validation is "False".
66e5370 to
a49a9e6
Compare
| cpu: 0.5 | ||
| limits: | ||
| memory: 4Gi | ||
| memory: 64Gi |
There was a problem hiding this comment.
内存限制从 4Gi 直接提升到 64Gi(16 倍),这个幅度异常大。如果是为了应对特定场景的内存峰值,建议添加注释说明原因。如果是内存泄漏导致的 OOM,应该排查根因而不是单纯提高限制。
🔍 Code Review Comments1. [代码规范] 默认端口处理 |
YehongPan
left a comment
There was a problem hiding this comment.
Code Review
- [代码规范] 应确认前端是否正确处理了
window.location.port为空(默认端口 80/443)的情况,避免拼接出host:这样的无效 URL。
|
A2A over k8s is a solid architectural addition. The k8s-native approach (in-cluster service discovery, sidecar proxy) is well-chosen. Please ensure the fallback logic when the k8s environment is unavailable is tested. |
|
Bug 1: wrong substring truncation in pod name test expectations
# Line 751-752:
assert name == "mcp-test-service-tenant-1-user-123-a1b2c3d4" # tenant-1, not tenant-12
# Line 761-762:
assert name == "mcp-test-service-tenant-1-user-123-a1b2c3d4" # tenant-1, not tenant.1Same issue with "tenant 123" at line 772 — should be "tenant-1" not "tenant 1". |
|
Bug 2:
|
#3267
