Skip to content

feat(team): start team-page refresh — add Research Associates / Vibhav Setlur#215

Closed
VibhavSetlur wants to merge 2 commits into
ModelSEED:stagingfrom
VibhavSetlur:feat/team-page-update-vibhav
Closed

feat(team): start team-page refresh — add Research Associates / Vibhav Setlur#215
VibhavSetlur wants to merge 2 commits into
ModelSEED:stagingfrom
VibhavSetlur:feat/team-page-update-vibhav

Conversation

@VibhavSetlur
Copy link
Copy Markdown
Collaborator

Summary

Begin the team-page refresh Sam Seaver requested in Slack ("see if you can collect all the names, and add them to the page, including you of course"). Conservative first pass — additions only, no removals.

  • Adds a Research Associates section under Scientists in lib/data/team.ts.
  • Adds Vibhav Setlur (Research Associate, Argonne National Laboratory) as the first entry.
  • Makes TeamMember.imageSrc optional; app/team/page.tsx renders an initials avatar placeholder (with aria-label="<name> (photo pending)") when no image is present, so future names can be added incrementally as screenshots come in.
  • No existing team members removed.

Follow-ups (separate PRs)

  • Collect screenshots for new entries and replace placeholders.
  • Add other currently active members once confirmed by team leads (e.g., Qizhi Zhang, Andrew Freiburger).

Test plan

  • npx tsc --noEmit — clean
  • npm run lint — 0 errors (pre-existing warnings only, none in touched files)
  • npm run build/team prerenders successfully
  • Sam to verify rendered page in staging before merging to master

🤖 Generated with Claude Code

Per Sam Seaver's request, begin refreshing the team roster. This change adds
a "Research Associates" category and lists Vibhav Setlur (Argonne National
Laboratory). No existing entries removed.

Also makes TeamMember.imageSrc optional and renders an initials placeholder
in app/team/page.tsx when a member's photo is not yet available, so further
names can be added incrementally as screenshots arrive.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 3, 2026 16:54
@VibhavSetlur VibhavSetlur review requested due to automatic review settings June 3, 2026 16:54
The Biochem Integration Tests suite intentionally degrades to "skipped"
when staging.modelseed.org is unreachable, but the live probe in beforeAll
had no internal timeout — on slow CI networks the vitest hookTimeout
(10s) fired before the catch block could mark isApiAvailable = false,
turning the whole suite (and CI) red. Race the probe against an explicit
7s timer so the catch path always runs first; observed master CI flake
matched this same signature on 2026-06-03.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@VibhavSetlur
Copy link
Copy Markdown
Collaborator Author

Closing in favor of the proper review flow: feature branch → fork's staging → upstream staging (so my fork's staging always mirrors what's actually proposed for upstream).

The work itself isn't shipping yet — team-page refresh is paused while I focus on the higher-priority job-submission fix. The commits stay alive on the fork branch feat/team-page-update-vibhav and will reappear via the two-stage flow when ready.

@VibhavSetlur VibhavSetlur deleted the feat/team-page-update-vibhav branch June 4, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant