Skip to content

fix: guard empty free_token_index in InferBatch._filter #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sufubao wants to merge 1 commit into from
+6 −1
Closed

fix: guard empty free_token_index in InferBatch._filter #1391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lightllm/server/router/model_infer/infer_batch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,12 @@ def _filter(self, finished_request_ids: List[int]):
req.shm_req.shm_infer_released = True
self.shm_req_manager.put_back_req_obj(req.shm_req)

free_token_index = custom_cat(free_token_index)
# 线性注意力混合模型下，请求可能在未产生任何 kv (cur_kv_len == 0) 时被 abort，
# 此时 free_token_index 为空列表，custom_cat 无法处理空输入。
if len(free_token_index) != 0:
free_token_index = custom_cat(free_token_index)
else:
free_token_index = []
Comment on lines +286 to +289

@gemini-code-assist gemini-code-assist Bot Jul 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The else block is redundant because free_token_index is already initialized as an empty list [] at the beginning of the method. Additionally, we can use Python's idiomatic truthiness check if free_token_index: instead of if len(free_token_index) != 0: to make the code cleaner and more readable.

Suggested change
if len(free_token_index) != 0:
free_token_index = custom_cat(free_token_index)
else:
free_token_index = []
if free_token_index:
free_token_index = custom_cat(free_token_index)

self.req_manager.free(free_req_index, free_token_index)

finished_req_ids_set = set(finished_request_ids)
Expand Down
Loading