Celestial Events API - #115
Conversation
calmilamsy
left a comment
calmilamsy
left a comment
There was a problem hiding this comment.
Can't comment on the actual logic, I only gave this a cursory look before heading off for the night.
Suggestion: A few javadoc comments on the API classes at least would help folk figure out what's going on with celestial events.
|
The recent commit should properly address the requested changes |
|
About the registry: I was actually considering to use it but was not sure if it makes sense. Is it about preventing events from having identical names or something else entirely? |
|
A potentially more significant issue I just realized is that I am trying to merge into the master branch while I should be merging into a different branch due to this being a new feature. Should I change the target branch if this needs to be done on my end? |
|
The newline should be taken care of now |
3bfe7b5 to
560bb9c
Compare
mineLdiver
left a comment
mineLdiver
left a comment
There was a problem hiding this comment.
First review. Got some thoughts on the overall design of the API.
| * It is recommended to add the event to CelestialTimeManger for automatic management. | ||
| * Inheritance is possible to add custom logic. | ||
| */ | ||
| public class CelestialEvent { |
There was a problem hiding this comment.
Not the best name, considering Event suffix most likely indicates an UnsafeEvents event. Not sure what would be a good alternative though.
There was a problem hiding this comment.
I could replace the suffix with Interval which might actually be a better hint for what it is
|
Got my workspace fixed up, now I can continue work on the API |
|
Only thing left as far as I'm concerned is to detach event registering from world load and instead moving it to game init. |
|
I am glad this PR is being picked up again. Thank you for putting in the time and effort to get the biggest flaws sorted out |
…evelop 2.0.0-alpha.5
…evelop Fix Buildscript And a5.1
imagine not having proper handling for build metadata in maven and no proper handling of multiple identifiers in fabric loader, thus having no way of having different releases which are only different in the way they're built? crazy
…evelop 2.0.0-alpha.5.3
…evelop 2.0.0-alpha.5.4
…evelop 2.0.0-alpha.6
3 participants
The Celestial Events API now has all the primary features needed to be considered functional. There is also a handful of different example usages in the test mod. This should be ready to be included into Station API