Metadata-dependent rules for the block datafixer - #280
Open
Atilist wants to merge 11 commits into
Open
Conversation
calmilamsy
requested changes
Aug 17, 2026
calmilamsy
left a comment
calmilamsy
left a comment
Member
There was a problem hiding this comment.
Looks good to me otherwise, thanks for adding javadocs where mine missed them.
| * @param outputMeta New metadata | ||
| * @param id New identifier (including the namespace) | ||
| */ | ||
| public static void putStateMetaRule(int oldId, int meta, int outputMeta, String id) { |
Member
There was a problem hiding this comment.
outputMeta should be the last arg. (Applies to all methods like this one.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Expands the block datafixer with an intermediary data structure
MetaDependentIdConversionto allow for each metadata to output a different block ID and also change the output metadata. New rules can be added any time after a default rule is specified using aputStatemethod. Metadata stays the same whenever the default rule applies.An example of birch wood being converted to purple wool can be found in the test mod:
putStateMetaRule(17, 2, "minecraft:wool", 10);Documentation
New and existing block conversion methods for
StationFlatteningBlockSchemahave been documented so the code becomes easier to understand for other developers. Some other datafixer classes have been partially documented too.Compatibility
Most changes are inside the
StationFlatteningBlockSchemaclass. The existing methods have the same inputs as before so none of the old datafixer configurations are broken by this.