test(agent-core-v2): resolve MCP stdio fixture paths with fileURLToPath - #2790
Open
jonathansampson wants to merge 2 commits into
Open
test(agent-core-v2): resolve MCP stdio fixture paths with fileURLToPath#2790jonathansampson wants to merge 2 commits into
jonathansampson wants to merge 2 commits into
Conversation
new URL('./fixtures/...', import.meta.url).pathname yields a leading-slash
path like /C:/Users/... on Windows, which is not a usable filesystem path.
fileURLToPath is the documented, correct conversion — already used
elsewhere in this suite (test/lint/op-uniqueness.test.ts,
test/lint/vendor-name-gates.test.ts) for the same purpose.
|
commit: |
Contributor
Author
|
Failing test appears to be related to resource limitations. #2792 should resolve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new URL('./fixtures/...', import.meta.url).pathnameyields a leading-slash path like/C:/Users/...on Windows, which is not a usable filesystem path.fileURLToPathis the documented, correct conversion — already used elsewhere in this suite (test/lint/op-uniqueness.test.ts,test/lint/vendor-name-gates.test.ts) for the same purpose.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.