fix(vscode): report a busy session as turn.agent_busy, not an internal error - #2798
Open
matthiasgoergens wants to merge 1 commit into
Open
fix(vscode): report a busy session as turn.agent_busy, not an internal error#2798matthiasgoergens wants to merge 1 commit into
matthiasgoergens wants to merge 1 commit into
Conversation
…l error The busy rejections in SessionRuntime threw a plain Error, which emitError maps to code "internal" and the webview renders as "Internal error occurred." — alarming and wrong for what is simply "a response is already being generated". Throw KimiError with the existing turn.agent_busy code instead so the UI shows the mapped "A message is being sent. Please wait." with the real detail attached. Fixes MoonshotAI#2796
🦋 Changeset detectedLatest commit: b3fda7b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolve #2796
Problem
See linked issue. A prompt sent while a session is busy is rejected with a plain
Error, whichemitErrormaps to codeinternal, so the webview shows "Internal error occurred." for what is simply "a response is already being generated". When a turn wedges (see #1050), every subsequent message in that session shows the scary generic error with no hint about the real state.What changed
SessionRuntime.runTurnActionandbeginHostActionnow throwKimiError("turn.agent_busy", ...)instead of a plainError.emitErroralready special-casesKimiError, and the error table already mapsturn.agent_busy→ "A message is being sent. Please wait." — only the throw sites needed to change. Test expectations updated (kimi-runtime.test.ts,settings-store.test.ts) to assert the code and the user-facing message.Checklist
gen-changesetsskill, or this PR needs no changeset. (changeset included:kimi-codepatch)gen-docsskill, or this PR needs no doc update.