fix(agent-core-v2): flush wire before agent disposal - #2812
Draft
LouisDM wants to merge 2 commits into
Draft
Conversation
🦋 Changeset detectedLatest commit: 1a0b873 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Refs #2727
Problem
Agent removal waits for active turns and compaction, but it can dispose the agent scope before queued replayable wire records are flushed. In ACP, this allows
session/closeto return while the latest assistant content is not yet durable.On current
main, the normal-speed prompt/close path did not reproduce persistent loss. A controlled delayed wire append did reproduce the lifecycle race: agent removal completed before the final records were durable.What changed
@moonshot-ai/kimi-code.This closes the verified close/dispose durability gap without claiming to explain every persistent-history symptom reported in #2727.
Validation
pnpm --filter @moonshot-ai/agent-core-v2 exec vitest run test/session/agentLifecycle/agentLifecycle.test.ts(29 passed)pnpm --filter @moonshot-ai/acp-server exec vitest run test/close.test.ts test/lifecycle.test.ts(18 passed)pnpm --filter @moonshot-ai/agent-core-v2 typecheckpnpm --filter @moonshot-ai/acp-server typecheckpnpm --filter @moonshot-ai/agent-core-v2 lint:imports(1135 files checked)pnpm exec oxlint packages/agent-core-v2/src/session/agentLifecycle/agentLifecycleService.ts packages/agent-core-v2/test/session/agentLifecycle/agentLifecycle.test.tspnpm changeset status --since=origin/mainChecklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.