docs(moonbeam-engineering): add compile-with-tests step to cherry-pick verification#52
Merged
Merged
Conversation
…k verification The qa-cherry-picks verification flow confirmed cherry-picks via git but never checked the fork branch still built. Add a step requiring `cargo check --workspace --tests`, and document why `--tests` is mandatory: plain `cargo check --workspace` skips `#[cfg(test)]` modules and integration tests, so a broken test module can ride along undetected (as evm's `delegation.rs` did across stable branches).
RomarQ
reviewed
May 18, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a missing QA verification step to ensure fork branches created for cherry-pick validation actually compile including test targets, preventing regressions that only appear when #[cfg(test)] and integration tests are compiled.
Changes:
- Document a new “Verify the branch compiles” step in the
qa-cherry-picksverification flow. - Require running
cargo check --workspace --tests(and explain why--testsmatters).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RomarQ
approved these changes
May 18, 2026
…s.md Co-authored-by: Rodrigo Quelhas <22591718+RomarQ@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a "Verify the branch compiles" step to the
qa-cherry-picksskill'sverify-cherry-picks.md, requiringcargo check --workspace --testsduring fork-branch QA.Why
The verification flow confirmed cherry-picks via git but never checked that the fork branch still built. Plain
cargo check --workspaceskips#[cfg(test)]modules and integration tests, so a cherry-pick — or an upstream refactor it lands on top of — can leave a test module that no longer compiles while the check still reports success.This was hit during the stable2603 cycle: evm's
evm-coredelegation.rstest module had been broken since anOption→ResultAPI refactor, and a--tests-less check let it ride along undetected from one stable branch to the next. (Since fixed upstream: rust-ethereum/evm#405.)