Fix handling of array types in dependency resolution#248
Fix handling of array types in dependency resolution#248
Conversation
Array types like `String[]` should not be considered mockable dependencies. Updated `Dependencies` resolution logic to use `Signature.getArrayCount()` to identify array types in constructors, fields, and setters, and skip them when building the dependency list. Added `should_ignore_array_types` to `DependenciesTest` to verify. Co-authored-by: RoiSoleil <3462260+RoiSoleil@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
@jules il y a des tests en erreur |
Yes, I see the test errors on CI. The failing tests are located in |
Array types like `String[]` should not be considered mockable dependencies. Updated `Dependencies` resolution logic to use `Signature.getArrayCount()` to identify array types in constructors, fields, and setters, and skip them when building the dependency list. Added `should_ignore_array_types` to `DependenciesTest` to verify. Co-authored-by: RoiSoleil <3462260+RoiSoleil@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #248 +/- ##
============================================
+ Coverage 73.28% 73.57% +0.28%
- Complexity 3234 3261 +27
============================================
Files 420 422 +2
Lines 14435 14563 +128
Branches 1266 1273 +7
============================================
+ Hits 10578 10714 +136
+ Misses 3325 3308 -17
- Partials 532 541 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Array types like
String[]should not be considered mockable dependencies.Updated
Dependenciesresolution logic to useSignature.getArrayCount()to identify array types in constructors, fields, and setters, and skip
them when building the dependency list.
Added
should_ignore_array_typestoDependenciesTestto verify.PR created automatically by Jules for task 9389838677659889251 started by @RoiSoleil