Skip to content

build: fixes for cr-destol gradle build and cleanup - #55

Merged
BenjaminAmos merged 3 commits into
masterfrom
fix/build-fixes
Jul 29, 2026
Merged

build: fixes for cr-destol gradle build and cleanup#55
BenjaminAmos merged 3 commits into
masterfrom
fix/build-fixes

Conversation

@BenjaminAmos

Copy link
Copy Markdown
Contributor

The pull request fixes the cr-destol build by adding back the missing repositories block. It also removes some obsolete Terasology specific configuration logic from settings.gradle.kts that has not been used in a long time, since Terasology moved to using more robust Gradle composite builds.

Terasology has used more the robust includeBuild for library dependencies for some time now.
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@BenjaminAmos, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 48 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ae8b0f89-a773-4dc1-8c10-8a31df190587

📥 Commits

Reviewing files that changed from the base of the PR and between 1d00683 and 1189021.

📒 Files selected for processing (2)
  • cr-destsol/build.gradle.kts
  • cr-terasology/build.gradle.kts
📝 Walkthrough

Walkthrough

Gradle configuration now resolves destination-module dependencies from Terasology Artifactory, Maven Central, and JBoss repositories. Module inclusion is simplified to always use the cr-core, cr-destsol, and cr-terasology paths.

Changes

Gradle build wiring

Layer / File(s) Summary
Repository and module configuration
settings.gradle.kts, cr-destsol/build.gradle.kts
Dependency repositories are added for cr-destsol, and settings unconditionally includes the three CrashReporter modules using unprefixed paths.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: soloturn

Poem

I’m a rabbit with a Gradle plan,
Repositories hop where dependencies can.
Modules now follow a simpler track,
No nested paths to double back.
Build files thump—clean and bright!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the Gradle build fix and cleanup reflected in the changed Gradle files.
Description check ✅ Passed The description matches the changes: restoring repositories and removing obsolete Terasology-specific settings.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/build-fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
cr-destsol/build.gradle.kts (1)

17-20: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick win

Restrict the JBoss repository to required modules.

cr-core/build.gradle.kts:40-50 filters this repository to org:jpastebin, but cr-destsol enables the entire public JBoss repository. Mirror that filter here, or explicitly list the additional required modules, to avoid unnecessarily broad dependency resolution.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@cr-destsol/build.gradle.kts` around lines 17 - 20, Restrict the JBoss Maven
repository declared in cr-destsol’s repositories configuration to the required
modules instead of allowing the entire public repository. Mirror the existing
org:jpastebin content filter used by cr-core, or explicitly include only the
additional dependencies needed by cr-destsol.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@cr-destsol/build.gradle.kts`:
- Around line 17-20: Restrict the JBoss Maven repository declared in
cr-destsol’s repositories configuration to the required modules instead of
allowing the entire public repository. Mirror the existing org:jpastebin content
filter used by cr-core, or explicitly include only the additional dependencies
needed by cr-destsol.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 58316720-d28e-4a16-bbc9-51946278d3a1

📥 Commits

Reviewing files that changed from the base of the PR and between c2db9ec and 1d00683.

📒 Files selected for processing (2)
  • cr-destsol/build.gradle.kts
  • settings.gradle.kts

@BenjaminAmos
BenjaminAmos merged commit b5bbf63 into master Jul 29, 2026
6 checks passed
@BenjaminAmos
BenjaminAmos deleted the fix/build-fixes branch July 29, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant