Update fhicl configuration#375
Open
AndrewEdmonds11 wants to merge 9 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes major changes to the fhicl configuration structure for EventNtuple. I had Sonnet take a first pass and then I made some manual tweaks.
The highlights:
trk,calo, andcrvbranches that can be individually turned on/off with e.g.trk.fill : falseEventNtuple.mc.fill : false)branchesis nowtrk.fits, which is a better descriptionbranchis nowbranchname(i.e. you now dotrk.fits[0].branchname : "dem"if you wanted to separate the fits into separate branches)I've also added a new and improved validation script that can be more easily extended to new fcl files. I have added:
from_dig-OnSpill.fcl,from_dig-calo.fcl, andfrom_mcs-Run1B.fclto the suite of fcl files that are tested. See the updated validation README.md for more information.
This will hopefully go some way to resolving #349, #371, and #373.