Fix Folia support detection for paper plugins#72
Open
twisti-dev wants to merge 1 commit into
Open
Conversation
- introduce foliaSupported boolean in PaperPluginMeta - update PluginDescriptionFile constructor to accept foliaSupported parameter - modify PaperPluginClassLoader to utilize foliaSupported for plugin loading - implement isFoliaSupported method in PluginMeta interface - adjust SynchronousPluginExecution to check folia support from PluginMeta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, plugins using the new
paper-plugin.ymlformat were not detected as Folia-compatible, even when they explicitly declared Folia support.This caused those plugins to be treated as unsupported and potentially forced into synchronous execution.
This PR fixes the detection by exposing
isFoliaSupported()throughPluginMetaand using the plugin metadata directly when checking whether a plugin supports Folia. It also forwards thefolia-supportedvalue fromPaperPluginMetainto the generatedPluginDescriptionFile, keeping support checks consistent for both legacy and modern plugin metadata.