DEV-1449#38
Open
Radrick19 wants to merge 19 commits into
Open
Conversation
added 12 commits
July 3, 2026 10:19
a-trofimov
reviewed
Jul 7, 2026
| } while (ldapPacket.Data.Length > 0); | ||
| } | ||
| catch (IOException) | ||
| catch (IOException) when (_closing) |
Collaborator
There was a problem hiding this comment.
А почему здесь when (_closing) используется только для IOException? Может стоит сделать для всех Exception?
Collaborator
Author
There was a problem hiding this comment.
Этот кэч ловит единственный кейс, который логировать не нужно: когда клиент или сервер рвут соединение, а вторая сторона всё ещё пытается из него читать — тогда прилетает ожидаемый io exception. А если упадёт где-то ещё, это как раз хочется видеть в логах
Collaborator
There was a problem hiding this comment.
Есть вероятность что при _closing = true придет не IOException, а например какой-нибудь ObjectDisposedException и тогда мы попадем в обычный catch (Exception).
Предлагаю пока оставить как есть
a-trofimov
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 06.07.2026 | Add logging + fix packet reading
New
Added more logging across the adapter
Bugfixes
LDAP packets are now read more correctly, including packets split across
several TCP segments