Skip to content

Job request support for pennylane#8

Open
annkay108 wants to merge 3 commits into
Munich-Quantum-Software-Stack:developfrom
annkay108:feat/nk/jobRequest-support-for-pennylane
Open

Job request support for pennylane#8
annkay108 wants to merge 3 commits into
Munich-Quantum-Software-Stack:developfrom
annkay108:feat/nk/jobRequest-support-for-pennylane

Conversation

@annkay108
Copy link
Copy Markdown
Collaborator

No description provided.

@annkay108 annkay108 requested a review from mnfarooqi May 20, 2025 12:40
@mnfarooqi
Copy link
Copy Markdown
Collaborator

@annkay108
The CI pipeline is failing. Run the pre-commit check and resolve any issues before pushing changes.

Comment thread mqss_client/job.py


@dataclass
class PennylaneJobRequest(JobRequest):
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bmete7
The PennylaneJobRequest is same as CircuitJobRequest. Why do we need a another class type for it? isn't the Pennylane at the end submit a circuit?
If there is any additional arguments needed that can be added.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small comment on the topic @mnfarooqi @annkay108 :
We are planning to change the format of the submitted circuit with the new release of PennylaneAdapter. Therefore, we decided to create a separate class for it, such that the transition to the new format would be smoother.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For any new format, only the value of circuit_format needs to be changed. The circuit itself needs to be serialised for communication purposes, so the circuit type remains the same, i.e. string or stream of bytes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants