[TASK] Test LineName::getArrayRepresentation()#1582
Conversation
oliverklee
added
testing
|
coverage: 73.3% (-0.02%) from 73.324% — task/array-rep/line-name into main |
JakeQZ
left a comment
JakeQZ
left a comment
There was a problem hiding this comment.
I've never used line names (aka named grid lines).
It seems that they are user-defined identifiers (i.e. strings), and that the LineName constructor should actually only allow strings in the $components parameter, not Values (for another PR).
In the meantime, we should be consistent with what the class is representing: a non-empty list of user-defined string identifiers, which are whitespace-separated in the rendered CSS.
oliverklee
force-pushed
the
task/array-rep/line-name
branch
from
560fb8c to
d97e895
Compare
I've added this to the Class PHPDoc in #1588.
I've entered #1589 for this. |
oliverklee
force-pushed
the
task/array-rep/line-name
branch
from
d97e895 to
f46a701
Compare
JakeQZ
left a comment
JakeQZ
left a comment
There was a problem hiding this comment.
There's a grammar mistake in a method name - otherwise looks good.
oliverklee
force-pushed
the
task/array-rep/line-name
branch
from
9020eb7 to
589d9ea
Compare
The tests are basically the same as those for the parent class `ValueList`. The main difference is that the default separator now is a space, not a comma. Part of #1440.
Co-authored-by: JakeQZ <jake.github@qzdesign.co.uk>
oliverklee
force-pushed
the
task/array-rep/line-name
branch
from
9659637 to
2b61dd9
Compare
3 participants
The tests are basically the same as those for the parent class
ValueList. The main difference is that the default separator now is a space, not a comma.Part of #1440.