Merged
Conversation
…cycle events (#24) * Initial plan * 完善 Protocol.v0.(zh-cn).md: 添加 cmd-resp 握手说明和通信流程图 Co-authored-by: nevstop <8196752+nevstop@users.noreply.github.com> * 根据审查意见更新 Protocol.v0.(zh-cn).md：修正包类型值、同步流程和异步流程图 Co-authored-by: nevstop <8196752+nevstop@users.noreply.github.com> * 根据审查意见修正 cmd-resp 注释、同步流程说明及异步流程图逻辑 Co-authored-by: nevstop <8196752+nevstop@users.noreply.github.com> * 统一 error 包描述，修正异步无返回流程文字与图表一致性 Co-authored-by: nevstop <8196752+nevstop@users.noreply.github.com> * Add info packet documentation for connection/disconnection events Co-authored-by: nevstop <8196752+nevstop@users.noreply.github.com> * Sync EN/ZH protocol and README files for consistency Co-authored-by: nevstop <8196752+nevstop@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nevstop <8196752+nevstop@users.noreply.github.com>
* #25 Completed the issues fix. Co-Authored-By: NEVSTOP <8196752+nevstop@users.noreply.github.com> * #26 Back-up >> works on interrupt * #26 Completed the interrupt mode and new Example 6 for demo this feature * change after code review --------- Co-authored-by: NEVSTOP <8196752+nevstop@users.noreply.github.com> Co-authored-by: nevstop <nevstop@NEVSTOP-LAB>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the TCP-Router client API and documentation to support new/renumbered packet types (including cmd-resp and separate status vs interrupt broadcasts), along with packaging/config adjustments for the 2026Q1 dev drop.
Changes:
- Updated protocol packet type definitions across READMEs and protocol docs, adding
cmd-respplus splitting subscription broadcasts intostatusandinterrupt. - Added a new client API VI (
Status-Request-ServerInstance-Name.vi) and updated class metadata for an existing VI item. - Updated VIPB package metadata/version/release notes and adjusted
.lvcsmmodule paths + status items.
Reviewed changes
Copilot reviewed 7 out of 15 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/_addons/TCP-Router/ClientAPI/TcpRouter-Client.lvclass | Adds a new static VI item to the client class and updates class item metadata. |
| README.md | Updates packet type list and numeric IDs; documents welcome/goodbye semantics for info. |
| README(zh-cn).md | Updates header layout diagram and packet type list/IDs in Chinese README. |
| CSM-TCP-Router.vipb | Bumps package version and adds release notes entry. |
| CSM-TCP-Router.lvcsm | Changes module paths to include src/ and adds status/history entries. |
| .doc/Protocol.v0.(zh-cn).md | Updates packet type IDs and adds detailed communication flow diagrams/handshake semantics. |
| .doc/Protocol.v0.(en).md | Same as above in English. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
删除这个文件, 并 ignore Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
@copilot review readme (en/ch)，让两边同步，并且更加的地道、通顺、简洁且容易阅读。 |
Agent-Logs-Url: https://github.com/NEVSTOP-LAB/CSM-TCP-Router-App/sessions/62cc62ad-c940-4e13-9a74-7c924ca9d168 Co-authored-by: nevstop <8196752+nevstop@users.noreply.github.com>
Contributor
Done in commit Both (synced):
English:
Chinese:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.