Skip to content

feat: add additional fields check into csv readers#109

Merged
georgeRobertson merged 3 commits into
release_v08from
feature/gr-desd-51-add_csv_schema_validation
Jun 5, 2026
Merged

feat: add additional fields check into csv readers#109
georgeRobertson merged 3 commits into
release_v08from
feature/gr-desd-51-add_csv_schema_validation

Conversation

@georgeRobertson
Copy link
Copy Markdown
Contributor

@georgeRobertson georgeRobertson commented May 28, 2026

TLDR of changes

  • add check into csv readers to raise a MessageBearingError if a csv file contains additional fields that are not expected. This is a feature that can be toggled on and off with field_check = True
  • refactored the missing check in csv readers as well

What kind of changes does this PR introduce?

Tick all that apply

  • fix: A bug fix. Correlates with PATCH in SemVer
  • feat: A new feature. Correlates with MINOR in SemVer
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • refactor: A code change that neither fixes a bug nor adds a feature
  • perf: A code change that improves performance
  • test: Adding missing or correcting existing tests
  • build: Changes that affect the build system or external dependencies (example scopes: pip, docker, npm)
  • ci: Changes to CI configuration files and scripts (example scopes: GitLabCI)

Please check if the PR fulfills these requirements

  • I have read and followed the Contributing guidance
  • Docs have been added / updated
  • Tests and Linting in the CI are passing
  • Changes have been reviewed and approved by a Project Maintainer

refactored the missing check in csv readers as well
@georgeRobertson georgeRobertson requested a review from stevenhsd May 28, 2026 10:18
…n't trigger additional fields check for csv

restructured the reader tests as well
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 5, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
5.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@georgeRobertson georgeRobertson merged commit f6d6424 into release_v08 Jun 5, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant