Add prod approval gate after int#45
Open
UmeshBangaNHS wants to merge 1 commit into
Open
Conversation
|
This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket: APM-000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an explicit manual approval stage between
intandprodin the release pipeline.This prevents the production deployment from starting immediately after the existing non-prod stages and makes the intended release order:
internal-devintprod_approvalprodValidation
origin/mastercontains onlyazure/azure-release-pipeline.yml.git diff --check origin/master..HEAD -- azure/azure-release-pipeline.yml.azure/azure-release-pipeline.ymlwithPyYAMLfrom the repo virtualenv.intdepends oninternal_devprod_approvaldepends onintproddepends onprod_approvalprod_requires_approval: falseNHSDigital/api-management-utilsedgetemplates support explicitmanual-approvaldeployments and pass throughmanual_approval_envanddepends_on.Azure still needs to validate the full server-side template expansion on the PR.