CCM-18178: enter OTP#983
Open
alexnuttall wants to merge 42 commits into
Open
Conversation
harrim91
reviewed
Jun 2, 2026
harrim91
reviewed
Jun 2, 2026
andykay-nhs
reviewed
Jun 2, 2026
Comment on lines
+154
to
+155
| expect(JSON.parse(lastCall.data)).toEqual(input); | ||
| expect(lastCall.headers).toEqual( |
Contributor
There was a problem hiding this comment.
These seem like nice checks to add to the other tests?
| value: 'unverified@nhs.net', | ||
| }); | ||
|
|
||
| const contactDetailSmsError = makeUnverifiedEmailContactDetail({ |
Contributor
There was a problem hiding this comment.
Suggested change
| const contactDetailSmsError = makeUnverifiedEmailContactDetail({ | |
| const contactDetailSmsError = makeUnverifiedSmsContactDetail({ |
ClareJonesBJSS
approved these changes
Jun 5, 2026
ClareJonesBJSS
previously approved these changes
Jun 5, 2026
|
|
||
| if (!contactDetail) { | ||
| // TODO CCM-18512: use a more appropriate URL | ||
| return redirect('/invalid-template', RedirectType.replace); |
Contributor
There was a problem hiding this comment.
For the proofing request pages, we ended up redirecting to /message-templates instead. Should probably be consistent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
enter-security-code page, which works for both email and SMS:
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.