Skip to content

CCM-8377: SMS send confirmation screen#984

Open
ClareJonesBJSS wants to merge 11 commits into
mainfrom
feature/CCM-8377_sms-send-confirmation
Open

CCM-8377: SMS send confirmation screen#984
ClareJonesBJSS wants to merge 11 commits into
mainfrom
feature/CCM-8377_sms-send-confirmation

Conversation

@ClareJonesBJSS
Copy link
Copy Markdown
Contributor

@ClareJonesBJSS ClareJonesBJSS commented Jun 2, 2026

Description

Confirmation screen for sms proof:

Screenshot 2026-06-02 at 12 29 21

Plus various small edits to email/app equivalents so everything matches

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@ClareJonesBJSS ClareJonesBJSS requested a review from a team as a code owner June 2, 2026 11:30
@ClareJonesBJSS ClareJonesBJSS changed the base branch from main to feature/CCM-8367_NHSAPP_test_message_confirmation_screen June 2, 2026 11:32
@ClareJonesBJSS ClareJonesBJSS force-pushed the feature/CCM-8377_sms-send-confirmation branch from f765efa to 20491d0 Compare June 2, 2026 14:19
@ClareJonesBJSS ClareJonesBJSS changed the base branch from feature/CCM-8367_NHSAPP_test_message_confirmation_screen to main June 2, 2026 14:21
Comment thread tests/test-team/pages/sms/template-mgmt-test-text-message-sent-page.ts Outdated
Comment thread frontend/src/app/test-text-message-sent/[proofingRequestId]/page.tsx Outdated
@ClareJonesBJSS ClareJonesBJSS force-pushed the feature/CCM-8377_sms-send-confirmation branch 5 times, most recently from fde8846 to 52e7ea4 Compare June 4, 2026 12:22
@ClareJonesBJSS ClareJonesBJSS force-pushed the feature/CCM-8377_sms-send-confirmation branch from 52e7ea4 to 0a6e2fd Compare June 4, 2026 12:39
alexnuttall
alexnuttall previously approved these changes Jun 4, 2026
Comment thread tests/test-team/pages/sms/template-mgmt-test-text-message-sent-page.ts Outdated
@ClareJonesBJSS ClareJonesBJSS force-pushed the feature/CCM-8377_sms-send-confirmation branch from f312ec3 to 43bbadc Compare June 5, 2026 14:43
<Link
href={interpolate(backLink.href, {
templateId: proofingRequest.templateId,
templateId: templateId,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
templateId: templateId,
templateId,

nicki-nhs
nicki-nhs previously approved these changes Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants