WPP-11685-updated PR workflow#169
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the PR lint GitHub Actions workflow to recognize WPP-#### ticket branch names and use them when posting JIRA links on PRs.
Changes:
- Extend branch-name validation regex to include
wpp-[0-9]+. - Extend ticket extraction and PR-comment conditions to include
wpp-/WPP-.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket: WPP-11685 |
from the pr-lint workflow
from the pr-lint workflow
in the pr-lint workflow
for use when a Jira ticket number has not been included in the branch
in check ticket name step
in the comment on pr with ticket number step
to use built-in bash commands rather than grep for pattern matching
|
This branch is work on a ticket in the NHS Digital WPP JIRA Project. Here's a handy link to the ticket: WPP-11685 |
edwardbowyer-nhs
left a comment
There was a problem hiding this comment.
Looks good to me, can see it working in both happy and sad paths.
Is there corss-over with Utilities we could make use of to ?
|
as mentioned in teams - this might replicate some of the existing checks done in the reusable actions myself and @chetan-nhs-acn have been working on and the existing RAA ones, can you take a look at the actions we have just to ensure we aren't duplicating anything, particarly the branch and PR title validation |
Summary
This pull request introduces changes to the PR Quality Check GitHub Actions workflow (pr-lint.yaml) to enable it to post a comment on the PR with a link a WPP Jira Ticket, when one is included in the branch name from which the PR is created. This type of feature existed previously in this workflow but it didn't work for tickets with out current WPP Jira prefix. These changes also remove the ability for no-longer-used Jira ticket prefixes, such as APM and AMP, to trigger the creation of a comment.
Additional changes:
Check ticket name conforms to requirementsstep has been refactored to use built-in bash commands rather thangrep, as pattern matching can be achieved without spawning a subprocess to run grep, which is slightly more efficient.Unchanged:
dependabot/are still valid and will not cause the PR Quality Check to fail.TESTING:
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.