Te/synergi reader#68
Open
tarekelgindy wants to merge 19 commits into
Open
Conversation
…na MDB - Remove pdb.set_trace() calls in geometry_branch and geometry_branch_equipment - Add fallback values (0.001) for zero conductor diameter, GMR, resistance with TODO comments flagging these need proper data fixes in future - Use fallback ampacity of 600A when ContinuousCurrentRating/InterruptCurrentRating is zero - Guard against empty conductor lists in GeometryBranchEquipment - Wrap component parse loops in try/except to skip bad rows with warnings - Fix insulation_thickness check: use <= 0 instead of == 0 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ase_phases in utils.py
…in equipment and compoents that they have
zzink-nrel
reviewed
May 11, 2026
| components = [] | ||
| for idx, row in table_data.iterrows(): | ||
| try: | ||
| if component_type == "GeometryBranchEquipment": |
Contributor
There was a problem hiding this comment.
Certainly some complexity to be saved here.
zzink-nrel
reviewed
May 11, 2026
|
|
||
| def map_pct_full_load_loss(self, row): | ||
| return 0 | ||
|
|
Contributor
There was a problem hiding this comment.
Is full load loss not reported?
zzink-nrel
reviewed
May 11, 2026
| def map_windings(self, row): | ||
| winding1 = WindingEquipmentMapper(self.system).parse(row, 1) | ||
| winding2 = WindingEquipmentMapper(self.system).parse(row, 2) | ||
| return [winding1, winding2] |
Contributor
There was a problem hiding this comment.
I guess no 3 winding xfmrs?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved synergi reader validated on larger datasets.