Skip to content

preview of future fre.cmor#842

Closed
ilaflott wants to merge 51 commits into
NOAA-GFDL:mainfrom
ilaflott:prerelease-frecmor
Closed

preview of future fre.cmor#842
ilaflott wants to merge 51 commits into
NOAA-GFDL:mainfrom
ilaflott:prerelease-frecmor

Conversation

@ilaflott
Copy link
Copy Markdown
Member

@ilaflott ilaflott commented Apr 7, 2026

Describe your changes

the branch/fork is a merge of multiple in-development features across branches in other PRs. which ones is tracked in the script to_merge.sh. this PR is not actually for merging/review, it is for previewing how things for fre.cmor are coming together, and having the assoc. pipelines provide feedback.

currently merged into this branch :

todo, more important to check, direct influence on fre.cmor:

todo, lower priority, parallel to fre.cmor or trivially relevant:

ilaflott and others added 30 commits April 1, 2026 09:45
- In test_remap_pp_components.py: replaced 3 nccmp -d calls with
  xr.testing.assert_equal, renamed test_nccmp_* to test_compare_*
- In test_split_netcdf.py: replaced nccmp -d with xr.testing.assert_equal
  for data tests, replaced nccmp -mg with xr.testing.assert_identical
  for metadata tests

Agent-Logs-Url: https://github.com/NOAA-GFDL/fre-cli/sessions/288da653-c4d3-4b41-bc3b-d062092ae272

Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
…sing netCDF4+numpy

Agent-Logs-Url: https://github.com/NOAA-GFDL/fre-cli/sessions/b75a9df0-9832-414c-89bd-10bc365552bf

Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
Fix logic for file comparison results in test.
…ion warnings, remove from required deps

Agent-Logs-Url: https://github.com/NOAA-GFDL/fre-cli/sessions/83cd5af3-5071-4657-ba27-a32d87e1ded5

Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
Agent-Logs-Url: https://github.com/NOAA-GFDL/fre-cli/sessions/83cd5af3-5071-4657-ba27-a32d87e1ded5

Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
…er, update tests and pylintrc

Agent-Logs-Url: https://github.com/NOAA-GFDL/fre-cli/sessions/1c5f6605-f239-4dd0-94b7-53b5458889fd

Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
…er weighted average

Agent-Logs-Url: https://github.com/NOAA-GFDL/fre-cli/sessions/1fb856bc-30a4-4be7-bb77-b2f42b051266

Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
…ghted seas/month parametrized cases

Agent-Logs-Url: https://github.com/NOAA-GFDL/fre-cli/sessions/ac9c29b8-e26b-4463-804e-8f22154798d3

Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
…65_day aliases)

Agent-Logs-Url: https://github.com/NOAA-GFDL/fre-cli/sessions/757f704b-98a8-4a6a-8099-0810c9981656

Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
Copilot AI and others added 21 commits April 3, 2026 19:14
…atches table format

Agent-Logs-Url: https://github.com/NOAA-GFDL/fre-cli/sessions/5f7a982a-1ccb-4536-94ea-694984b5bd0d

Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
…t-remap-pp-components' into prerelease-frecmor
…s together as a prerelease for the frecmor submodule
@ilaflott ilaflott self-assigned this Apr 7, 2026
@ilaflott ilaflott added the tricky Likely to encounter significant friction to solution label Apr 7, 2026
@ilaflott
Copy link
Copy Markdown
Member Author

ilaflott commented Apr 7, 2026

first observation, conda environment creation is clocking in at two whole minutes faster than main

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 7, 2026

Codecov Report

❌ Patch coverage is 77.68240% with 52 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.95%. Comparing base (836559e) to head (156a1d1).

Files with missing lines Patch % Lines
fre/cmor/cmor_init.py 53.12% 30 Missing ⚠️
...p/generate_time_averages/frenctoolsTimeAverager.py 4.54% 21 Missing ⚠️
...e/app/generate_time_averages/xarrayTimeAverager.py 98.97% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #842      +/-   ##
==========================================
- Coverage   84.12%   83.95%   -0.17%     
==========================================
  Files          71       73       +2     
  Lines        4944     5098     +154     
==========================================
+ Hits         4159     4280     +121     
- Misses        785      818      +33     
Flag Coverage Δ
unittests 83.95% <77.68%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
fre/app/freapp.py 97.14% <ø> (ø)
fre/app/generate_time_averages/__init__.py 100.00% <ø> (ø)
fre/app/generate_time_averages/cdoTimeAverager.py 100.00% <100.00%> (ø)
...p/generate_time_averages/frepytoolsTimeAverager.py 80.43% <100.00%> (+0.14%) ⬆️
...p/generate_time_averages/generate_time_averages.py 92.75% <100.00%> (+0.95%) ⬆️
fre/cmor/__init__.py 100.00% <100.00%> (ø)
fre/cmor/cmor_constants.py 100.00% <100.00%> (ø)
fre/cmor/cmor_helpers.py 93.83% <100.00%> (+0.04%) ⬆️
fre/cmor/cmor_mixer.py 89.96% <100.00%> (+0.09%) ⬆️
fre/cmor/frecmor.py 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 836559e...156a1d1. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ilaflott ilaflott changed the title Prerelease frecmor preview of future fre.cmor Apr 7, 2026
@ilaflott
Copy link
Copy Markdown
Member Author

can re-open this if needed. closing

@ilaflott ilaflott closed this Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tricky Likely to encounter significant friction to solution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants