chore(agentic-ci): declare pydantic as direct dep of data-designer-engine#752
Open
github-actions[bot] wants to merge 1 commit into
Open
chore(agentic-ci): declare pydantic as direct dep of data-designer-engine#752github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…gine The engine package imports pydantic in 23 source files (BaseModel, Field, field_validator, model_validator, ConfigDict, ValidationError) but only data-designer-config declared it. Installing data-designer-engine without data-designer-config would fail at import time. Add `pydantic>=2.9.2,<3` to the engine's direct dependencies, matching the config package's specifier. The `[email]` extra is intentionally omitted — engine source contains no `EmailStr`/`email_validator` usage; that extra remains config-only. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pydantic>=2.9.2,<3as a direct dependency ofdata-designer-engine.BaseModel,Field,field_validator,model_validator,ConfigDict,ValidationError) but the package previously relied ondata-designer-configto pull pydantic in transitively.data-designer-configpin. The[email]extra is intentionally omitted — engine has noEmailStr/email_validatorusage, so the extra stays config-only.Why
Without this, installing
data-designer-enginewithoutdata-designer-config(e.g. as a standalone dep) would fail at import time. Each package should declare what it directly imports.Test plan
make install-devresolves cleanly with the added dep.make test-engine— 2248 tests pass.This PR was opened automatically by the
dependenciesdaily agentic-CI suite. See the audit report and policy in.agents/recipes/_fix-policy.md.