Skip to content

chore(agentic-ci): declare pydantic as direct dep of data-designer-engine#752

Open
github-actions[bot] wants to merge 1 commit into
mainfrom
agentic-ci/chore/dependencies-20260616-engine-pydantic
Open

chore(agentic-ci): declare pydantic as direct dep of data-designer-engine#752
github-actions[bot] wants to merge 1 commit into
mainfrom
agentic-ci/chore/dependencies-20260616-engine-pydantic

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Summary

  • Declare pydantic>=2.9.2,<3 as a direct dependency of data-designer-engine.
  • Engine source imports pydantic in 23 files (BaseModel, Field, field_validator, model_validator, ConfigDict, ValidationError) but the package previously relied on data-designer-config to pull pydantic in transitively.
  • Specifier matches the existing data-designer-config pin. The [email] extra is intentionally omitted — engine has no EmailStr / email_validator usage, so the extra stays config-only.

Why

Without this, installing data-designer-engine without data-designer-config (e.g. as a standalone dep) would fail at import time. Each package should declare what it directly imports.

Test plan

  • make install-dev resolves cleanly with the added dep.
  • make test-engine — 2248 tests pass.

This PR was opened automatically by the dependencies daily agentic-CI suite. See the audit report and policy in .agents/recipes/_fix-policy.md.

…gine

The engine package imports pydantic in 23 source files (BaseModel, Field,
field_validator, model_validator, ConfigDict, ValidationError) but only
data-designer-config declared it. Installing data-designer-engine without
data-designer-config would fail at import time.

Add `pydantic>=2.9.2,<3` to the engine's direct dependencies, matching the
config package's specifier. The `[email]` extra is intentionally omitted —
engine source contains no `EmailStr`/`email_validator` usage; that extra
remains config-only.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@github-actions github-actions Bot requested a review from a team as a code owner June 16, 2026 10:07
@github-actions github-actions Bot added agentic-ci Created by agentic-ci automation agentic-ci/dependencies Agentic CI - dependencies suite labels Jun 16, 2026
@greptile-apps

greptile-apps Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR declares pydantic as an explicit direct dependency of data-designer-engine, preventing import failures when the package is installed without data-designer-config. The specifier >=2.9.2,<3 aligns exactly with the existing pin in data-designer-config, and the [email] extra is correctly omitted since the engine has no EmailStr usage.

  • Adds "pydantic>=2.9.2,<3" to the data-designer-engine dependency list in alphabetical order, with no other changes.

Confidence Score: 5/5

Safe to merge — a one-line addition that correctly formalises an existing transitive dependency.

The change adds a single dependency pin that matches the version already resolved transitively via data-designer-config, with the [email] extra correctly omitted. There are no behavioural changes and no other files are touched.

No files require special attention.

Important Files Changed

Filename Overview
packages/data-designer-engine/pyproject.toml Adds pydantic>=2.9.2,<3 as a direct dependency; version specifier matches data-designer-config, alphabetically ordered, [email] extra correctly omitted.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[data-designer-engine] -->|pydantic>=2.9.2 direct dep| P[pydantic]
    A -->|data-designer-config| B[data-designer-config]
    B -->|pydantic email>=2.9.2 direct dep| P
    style A fill:#4a90d9,color:#fff
    style P fill:#6abf69,color:#fff
    style B fill:#888,color:#fff
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[data-designer-engine] -->|pydantic>=2.9.2 direct dep| P[pydantic]
    A -->|data-designer-config| B[data-designer-config]
    B -->|pydantic email>=2.9.2 direct dep| P
    style A fill:#4a90d9,color:#fff
    style P fill:#6abf69,color:#fff
    style B fill:#888,color:#fff
Loading

Reviews (1): Last reviewed commit: "chore(agentic-ci): declare pydantic as d..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agentic-ci/dependencies Agentic CI - dependencies suite agentic-ci Created by agentic-ci automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants