Skip to content

Remove the PnC flag from the ASR inference pipelines#15591

Merged
naymaraq merged 11 commits intomainfrom
dkaramyan/rm-pnc-flag
Apr 14, 2026
Merged

Remove the PnC flag from the ASR inference pipelines#15591
naymaraq merged 11 commits intomainfrom
dkaramyan/rm-pnc-flag

Conversation

@naymaraq
Copy link
Copy Markdown
Collaborator

@naymaraq naymaraq commented Apr 8, 2026

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [ASR]

Changelog

Remove the PnC flag since external PnC is no longer used; rely on ASR output instead.

Summary

  • Remove the enable_pnc flag from the streaming ASR inference pipeline — the per-request and global PnC on/off toggle is no longer needed since PnC output is now always preserved as-is from the ASR model
  • Remove associated dead code
  • Update all pipeline configs (YAML), pipeline implementations, request options, and the streaming tutorial notebook to reflect the removal
  • Add functional tests for cache-aware pipelines
  • Rename augment_with_default -> fill_defaults

Verification

Model: nvidia/nemotron-speech-streaming-en-0.6b

In main, enable_pnc=True is explicitly set. This branch removes enable_PnC flag. This comparison verifies that the change has no impact on WER.

Dataset main this PR Diff
AMI 13.7544 13.7544 0.0000
Earnings22 Test 12.7078 12.7078 0.0000
Gigaspeech Test 9.7836 9.7836 0.0000
Librispeech Test Clean 2.3837 2.3837 0.0000
Librispeech Test Other 4.9110 4.9110 0.0000
Spgispeech Test 3.0050 3.0050 0.0000
Tedlium Test 3.4708 3.4708 0.0000
Voxpopuli Test 8.0605 8.0605 0.0000

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

naymaraq added 5 commits April 8, 2026 15:38
Signed-off-by: naymaraq <dkaramyan@nvidia.com>
Signed-off-by: naymaraq <dkaramyan@nvidia.com>
Signed-off-by: naymaraq <dkaramyan@nvidia.com>
Signed-off-by: naymaraq <dkaramyan@nvidia.com>
Signed-off-by: naymaraq <dkaramyan@nvidia.com>
@github-actions github-actions bot added the ASR label Apr 8, 2026
@naymaraq naymaraq changed the title Dkaramyan/rm pnc flag Remove the “enable PnC” flag and its associated code from the ASR inference pipelines. Apr 8, 2026
@naymaraq naymaraq changed the title Remove the “enable PnC” flag and its associated code from the ASR inference pipelines. Remove the enable_PnC flag and its associated code from the ASR inference pipelines. Apr 8, 2026
@naymaraq naymaraq changed the title Remove the enable_PnC flag and its associated code from the ASR inference pipelines. Remove the PnC flag from the ASR inference pipelines. Apr 8, 2026
@naymaraq naymaraq changed the title Remove the PnC flag from the ASR inference pipelines. Remove the PnC flag from the ASR inference pipelines Apr 8, 2026
naymaraq and others added 5 commits April 8, 2026 16:31
Signed-off-by: Dav Karamyan <47416614+naymaraq@users.noreply.github.com>
Signed-off-by: naymaraq <naymaraq@users.noreply.github.com>
Signed-off-by: naymaraq <dkaramyan@nvidia.com>
Signed-off-by: naymaraq <dkaramyan@nvidia.com>
Signed-off-by: naymaraq <naymaraq@users.noreply.github.com>
@naymaraq naymaraq marked this pull request as ready for review April 8, 2026 13:17
Signed-off-by: naymaraq <dkaramyan@nvidia.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

[🤖]: Hi @naymaraq 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

@naymaraq
Copy link
Copy Markdown
Collaborator Author

naymaraq commented Apr 9, 2026

/claude review

@NVIDIA-NeMo NVIDIA-NeMo deleted a comment from claude bot Apr 10, 2026
Copy link
Copy Markdown
Collaborator

@arushidNV arushidNV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@naymaraq naymaraq merged commit fb44f67 into main Apr 14, 2026
134 checks passed
@naymaraq naymaraq deleted the dkaramyan/rm-pnc-flag branch April 14, 2026 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants