Skip to content

ci: Install CI dependencies from uv lock#15697

Open
chtruong814 wants to merge 26 commits into
mainfrom
chtruong/uv-lock
Open

ci: Install CI dependencies from uv lock#15697
chtruong814 wants to merge 26 commits into
mainfrom
chtruong/uv-lock

Conversation

@chtruong814
Copy link
Copy Markdown
Collaborator

@chtruong814 chtruong814 commented May 13, 2026

Summary

  • Replace the CI Docker base with CUDA 13.1.2 and install dependencies with uv from pyproject.toml/uv.lock
  • Remove TE/Megatron-Core wheel stages and install_dep.sh usage from docker/Dockerfile.ci
  • Force Linux torch resolution to torch 2.10.0+cu130 and keep nemo_automodel pinned to the requirements manifest commit

Testing

  • UV_CACHE_DIR=/private/tmp/nemo-uv-cache /private/tmp/nemo-uv-latest/bin/uv lock --check
  • DOCKER_BUILDKIT=1 /opt/homebrew/bin/docker-buildx build --progress=plain -f docker/Dockerfile.ci -t nemo-ci-uv-test --load . (uv install completed; local image load failed due Docker disk space)

@chtruong814
Move requirements metadata to pyproject
882084f 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814
Update CI Dockerfile to install with uv
2e93ef9 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814 chtruong814 requested a review from a team as a code owner May 13, 2026 20:50
@chtruong814
Remove legacy requirements files
0d53a71 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814
Remove legacy Docker dependency installer
fb05691 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814 chtruong814 changed the title Install CI dependencies from uv lock ci: Install CI dependencies from uv lock May 13, 2026
@chtruong814
Fix container build
611aa64 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814
Copy link
Copy Markdown
Collaborator Author

chtruong814 commented May 13, 2026

/ok to test 611aa64

@github-actions github-actions Bot added the CI label May 13, 2026
@chtruong814
Fix nemo install
fd0cce2 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814
Copy link
Copy Markdown
Collaborator Author

chtruong814 commented May 14, 2026

/ok to test fd0cce2

@chtruong814
Add deps
186033e 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814
Update uv lock file
085a343 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814
Fix install
69d4607 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
chtruong814 and others added 2 commits May 21, 2026 22:24
@chtruong814
Add speech CI build ID label
bcc4980 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@pzelasko
Fix SpeechLM2 automodel data parallel rank
f72d5ab 
Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 27, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

pzelasko added 2 commits May 27, 2026 07:56
@pzelasko
Fix lint failures after dependency migration
88de033 
Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
@pzelasko
Merge branch 'main' into chtruong/uv-lock
fa5e5f9 
Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
@pzelasko
Copy link
Copy Markdown
Collaborator

pzelasko commented May 27, 2026

/ok to test 88de033

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 27, 2026

/ok to test 88de033

@pzelasko, there was an error processing your request: E2

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/

@pzelasko
Copy link
Copy Markdown
Collaborator

pzelasko commented May 27, 2026

/ok to test fa5e5f9

github-advanced-security[bot]
github-advanced-security AI found potential problems May 27, 2026
View reviewed changes
Comment thread nemo/collections/asr/data/feature_to_label.py Dismissed
@pzelasko
Copy link
Copy Markdown
Collaborator

pzelasko commented May 27, 2026

/ok to test 074a90a

artbataev
artbataev reviewed May 27, 2026
View reviewed changes
Comment thread pyproject.toml Outdated
],
]
override-dependencies = [
"torch==2.12.0+cu130 ; sys_platform == 'linux'",
Copy link
Copy Markdown
Collaborator

@artbataev artbataev May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use torch==2.12.0+cu132 since the base container is now with CUDA 13.2?

Copy link
Copy Markdown
Collaborator

@pzelasko pzelasko May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done + refreshed uv.lock

@pzelasko
Copy link
Copy Markdown
Collaborator

pzelasko commented May 27, 2026

/ok to test eca699c

@pzelasko
Copy link
Copy Markdown
Collaborator

pzelasko commented May 28, 2026

/ok to test 1eca063

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artbataev artbataev artbataev left review comments

@pzelasko pzelasko pzelasko left review comments

+1 more reviewer

@github-advanced-security github-advanced-security[bot] github-advanced-security[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ASR CI common core Changes to NeMo Core Run e2e nightly TTS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chtruong814 @pzelasko @artbataev @github-advanced-security