Skip to content

fix(libsy): update escalation judge param defaults to benchmarked values - #201

Merged
linj-glitch merged 1 commit into
mainfrom
linj/switch-1054-python-param-defaults
Jul 30, 2026
Merged

fix(libsy): update escalation judge param defaults to benchmarked values#201
linj-glitch merged 1 commit into
mainfrom
linj/switch-1054-python-param-defaults

Conversation

@linj-glitch

@linj-glitch linj-glitch commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Update the Python-side escalation judge defaults to match the benchmarked configuration: escalate_confirmations 1→2, recent_turn_window 14→28, window_message_chars 300→500, max_request_chars 12k→18k, judge_timeout_s 5→30. This is part 1 of breaking up PR #172.

Summary by CodeRabbit

  • Improvements

    • Escalation decisions now require two consecutive escalation verdicts by default, reducing premature escalations.
    • The judge receives more conversation context, including longer message windows and larger request limits.
    • Increased default evaluation timeout improves handling of more complex escalation assessments.
  • Tests

    • Updated coverage to validate the revised escalation defaults and preserve single-verdict behavior where explicitly configured.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 68589181-5532-437f-956c-587b859d3725

📥 Commits

Reviewing files that changed from the base of the PR and between f3ff7ff and b2ea07e.

📒 Files selected for processing (4)
  • switchyard/lib/processors/escalation_judge_request_processor.py
  • switchyard/lib/profiles/escalation_router_config.py
  • tests/test_escalation_judge_request_processor.py
  • tests/test_route_bundle.py

Walkthrough

The escalation judge now defaults to two consecutive escalation verdicts, larger transcript context limits, and a 30-second router timeout. Configuration documentation and tests were updated, while selected processor tests explicitly retain single-verdict behavior.

Changes

Escalation judge defaults

Layer / File(s) Summary
Processor confirmation and context defaults
switchyard/lib/processors/escalation_judge_request_processor.py, tests/test_escalation_judge_request_processor.py
Processor defaults require two escalation confirmations and allow larger judge transcript windows; focused tests explicitly set one confirmation where required.
Router configuration propagation
switchyard/lib/profiles/escalation_router_config.py, tests/test_route_bundle.py
Router judge defaults and documentation were updated for confirmation counts, context sizing, and timeout precedence; route bundle expectations reflect the new values.

Estimated code review effort: 2 (Simple) | ~10 minutes

Poem

I’m a rabbit hopping through the judge’s new tune,
Two little verdicts beneath the moon.
Bigger windows let context grow,
Thirty seconds give thoughts room to flow.
Tests keep old paths safely in view!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: updating escalation judge defaults to benchmarked values.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@linj-glitch
linj-glitch requested a review from ryan-lempka July 30, 2026 17:40
@linj-glitch
linj-glitch merged commit 54ae66c into main Jul 30, 2026
18 checks passed
@linj-glitch
linj-glitch deleted the linj/switch-1054-python-param-defaults branch July 30, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants