fix(libsy): restore judge classification test - #212
Closed
nachiketb-nvidia wants to merge 1 commit into
Closed
Conversation
Signed-off-by: nachiketb <nachiketb@nvidia.com>
ryan-lempka
approved these changes
Jul 30, 2026
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughChangesLLM Judge Selection
Estimated code review effort: 1 (Trivial) | ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
Contributor
|
I'll race you :-) #206 |
ayushag-nv
approved these changes
Jul 30, 2026
nachiketb-nvidia
enabled auto-merge (squash)
July 30, 2026 20:11
nachiketb-nvidia
disabled auto-merge
July 30, 2026 20:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Restore the
LlmJudgetest helper to pass theClassificationenum directly toselected.Why
PR #204 changed the helper to access tuple field
.0, butClassificationis an enum. This preventscargo clippy --workspace --all-targets -- -D warningsfrom compiling onmainand makes every subsequent CI run fail.Validation
cargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo test -p switchyard-libsyuv run ruff check .uv run maturin developuv run pytest tests/(1729 passed, 35 skipped)Summary by CodeRabbit