feat(studio): Filtering for ExperimentGroup DataView#243
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughTyped DataView state is added and experiment list queries merge the DataView's API filter with an enforced experiment_group_id. Table columns were refactored into a useCallback, timestamp columns use dateTimeFilter, Model Names rendering adjusted, and shared text-filter debouncing centralised via DebouncedTextInput. ChangesExperimentGroupDataView Filtering and Column Configuration
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@web/packages/studio/src/components/dataViews/ExperimentGroupDataView/index.tsx`:
- Around line 55-59: The dataView initialization hides only updated_at but not
created_by, so the created_by filter never appears; update the
useStudioDataViewState call (symbol: useStudioDataViewState<ExperimentFilter>)
to include created_by in columnVisibility (e.g., columnVisibility: { created_by:
false, updated_at: false }) and also ensure the columns definition used for this
DataView (the columns/columnsDefinition near the block around lines 194-206)
includes a hidden/filter-only column entry for created_by matching the same key
so the filter control is rendered but the column stays hidden.
- Line 22: The import line brings in React types ComponentProps and FC as
runtime imports; change it to use TypeScript's type-only import syntax by
importing ComponentProps and FC with "import type" (e.g., replace the existing
import that mentions ComponentProps and FC so the type-only symbols are imported
via import type) to satisfy TS rules and avoid bundling types at runtime.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 9834126d-5e23-480b-a9ad-b0958fdbdd6c
📒 Files selected for processing (1)
web/packages/studio/src/components/dataViews/ExperimentGroupDataView/index.tsx
|
5c03dff to
08dc67f
Compare
|
EDIT: IGNORE, these are violating existing studio patterns Looking good! Let's make these changes:
|
shanaiabuggy
left a comment
There was a problem hiding this comment.
Gorg! Left 1 comment inline.
Also nit: Can we add placeholders to the text filters? Like "Filter by agent name"
|
Added search bar, moved Screen.Recording.2026-06-10.at.10.36.31.AM.mov |
Signed-off-by: Nicholas Kolean <nakolean@gmail.com>
Signed-off-by: Nicholas Kolean <nakolean@gmail.com>
Signed-off-by: Nicholas Kolean <nakolean@gmail.com>
Signed-off-by: Nicholas Kolean <nakolean@gmail.com>
Signed-off-by: Nicholas Kolean <nakolean@gmail.com>
…ate DebouncedTextInput to use common DEFAULT_DEBOUNCE_MS timing, increase DEFAULT_DEBOUNCE_MS from 300 to 500 Signed-off-by: Nicholas Kolean <nakolean@gmail.com>
261bfa2 to
fefb014
Compare
Screen.Recording.2026-06-09.at.2.48.07.PM.mov
Summary by CodeRabbit
New Features
Bug Fixes / Improvements