Hi TN date class accuracy improvement#418
Open
shrpawar-alt wants to merge 10 commits intoNVIDIA:staging/hi_tn_v3from
Open
Hi TN date class accuracy improvement#418shrpawar-alt wants to merge 10 commits intoNVIDIA:staging/hi_tn_v3from
shrpawar-alt wants to merge 10 commits intoNVIDIA:staging/hi_tn_v3from
Conversation
Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com>
Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com>
shrpawar-alt
force-pushed
the
hi-tn-date-v2
branch
from
79f8c53 to
017a615
Compare
for more information, see https://pre-commit.ci
mgrafu
reviewed
Apr 28, 2026
mgrafu
reviewed
Apr 28, 2026
mgrafu
reviewed
Apr 28, 2026
mgrafu
reviewed
Apr 28, 2026
mgrafu
reviewed
Apr 28, 2026
mgrafu
reviewed
Apr 28, 2026
mgrafu
reviewed
Apr 28, 2026
mgrafu
reviewed
Apr 28, 2026
mgrafu
reviewed
Apr 28, 2026
mgrafu
reviewed
Apr 28, 2026
mgrafu
reviewed
Apr 28, 2026
…ion of more test cases Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com>
Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com>
for more information, see https://pre-commit.ci
…mm-yyyy, dd-m-yyyy and mm-yyyy Signed-off-by: Shreyas Pawar <shrpawar@nvidia.com>
for more information, see https://pre-commit.ci
mgrafu
reviewed
May 7, 2026
|
|
||
| # Create union of suffixes and prefixes | ||
| suffix_union = pynini.union(*suffixes_list) | ||
| prefix_union = pynini.union(*prefixes_list) |
Collaborator
There was a problem hiding this comment.
can l36 through here be replaced by string file?
mgrafu
reviewed
May 7, 2026
| ०४-०३~चार मार्च | ||
| 25-03-2020~पच्चीस मार्च दो हज़ार बीस | ||
| ३०-०५-२०७०~तीस मई दो हज़ार सत्तर | ||
| 12-07-1970~बारह जुलाई उन्नीस सौ सत्तर |
mgrafu
reviewed
May 7, 2026
| 12-07-1970~बारह जुलाई उन्नीस सौ सत्तर | ||
| ०९-१२-२१०१~नौ दिसंबर इक्कीस सौ एक | ||
| 23-08-2024~तेईस अगस्त दो हज़ार चौबीस | ||
| १०-२९-२०००~अक्टूबर उनतीस दो हज़ार |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Improved Date class accuracy from ~87 % to ~99 % by introducing additional graph coverage for the cases failing earlier.
Before your PR is "Ready for review"
Pre checks:
git commit -sto sign.pytestor (if your machine does not have GPU)pytest --cpufrom the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...pytestand Sparrowhawk here.__init__.pyfor every folder and subfolder, includingdatafolder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.to all newly added Python files?Copyright 2015 and onwards Google, Inc.. See an example here.try import: ... except: ...) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.