feat(vm): configure gpu settings through gateway vm config#1581
Draft
cheese-head wants to merge 3 commits into
Draft
feat(vm): configure gpu settings through gateway vm config#1581cheese-head wants to merge 3 commits into
cheese-head wants to merge 3 commits into
Conversation
Signed-off-by: Patrick Riel <priel@nvidia.com>
Signed-off-by: Patrick Riel <priel@nvidia.com>
elezar
reviewed
May 27, 2026
Comment on lines
+238
to
+240
| vcpus = 2 | ||
| mem_mib = 2048 | ||
| overlay_disk_mib = 4096 |
Member
There was a problem hiding this comment.
Do these need their own section?
elezar
reviewed
May 27, 2026
elezar
reviewed
May 27, 2026
Comment on lines
227
to
229
| guest_tls_ca = "/var/lib/openshell/guest-tls/ca.pem" | ||
| guest_tls_cert = "/var/lib/openshell/guest-tls/client.pem" | ||
| guest_tls_key = "/var/lib/openshell/guest-tls/client-key.pem" |
Member
There was a problem hiding this comment.
Are these setting VM-specific given the guest_ prefix?
elezar
reviewed
May 27, 2026
| vcpus = 2 | ||
| mem_mib = 2048 | ||
| krun_log_level = 1 | ||
| bootstrap_image = "" |
Member
There was a problem hiding this comment.
What does an empty image imply? Should we add a comment?
elezar
reviewed
May 27, 2026
| mem_mib = 2048 | ||
| krun_log_level = 1 | ||
| bootstrap_image = "" | ||
| krun_log_level = 1 |
Member
There was a problem hiding this comment.
Out of scope for this change, but why is this not just log_level?
Signed-off-by: Patrick Riel <priel@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the gateway VM driver config so
[openshell.drivers.vm]can express the existing GPU enablement and GPU sizing knobs. The gateway now resolves those VM settings and passes explicit arguments to theopenshell-driver-vmsubprocess, keeping VM configuration in the gateway TOML flow.Related Issue
N/A
Changes
gpu_enabled,gpu_mem_mib, andgpu_vcpustoVmComputeConfig.OPENSHELL_VM_*environment overrides when spawning the VM driver, while preventing the child process from re-reading stale config env values.Testing
mise run pre-commitpassesManual verification run:
Checklist