Skip to content

[https://nvbugs/6116088][fix] unwaive the ci test#15247

Closed
JadoTu wants to merge 2 commits into
NVIDIA:mainfrom
JadoTu:bugfix_6116088
Closed

[https://nvbugs/6116088][fix] unwaive the ci test#15247
JadoTu wants to merge 2 commits into
NVIDIA:mainfrom
JadoTu:bugfix_6116088

Conversation

@JadoTu

@JadoTu JadoTu commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Removed a waived test entry, re-enabling a previously skipped integration test case to execute during test runs.

Description

Not a Bug.

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: jiant <107457950+JadoTu@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR removes a single waived test entry from tests/integration/test_lists/waives.txt, unskipping TestQwen3NextInstruct::test_nvfp4[tp1-cutlass] to allow the test case to run in CI.

Changes

Test Waiver Removal

Layer / File(s) Summary
Remove waived test entry
tests/integration/test_lists/waives.txt
Deleted the waived test line for TestQwen3NextInstruct::test_nvfp4[tp1-cutlass], unskipping the test case in the integration test waives list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#15118: Both PRs modify tests/integration/test_lists/waives.txt by removing waiver entries to unskip previously waived CI tests.
  • NVIDIA/TensorRT-LLM#15061: Both PRs modify tests/integration/test_lists/waives.txt by removing waived test entries.
  • NVIDIA/TensorRT-LLM#15214: Both PRs modify tests/integration/test_lists/waives.txt by removing (unwaiving) accuracy test entries.

Suggested reviewers

  • crazydemo
  • nvchenghaoz
  • xinhe-nv
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is minimal and lacks required information such as clear explanation of the issue, solution, test coverage details, and PR title format. Provide a clear description explaining what the waived test was and why it is being un-waived. Include the test coverage section with details on how this change was validated.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: removing a waived test from the CI, directly addressing the PR's objective of unwaiving a previously skipped test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Jian Tu <107457950+JadoTu@users.noreply.github.com>
@JadoTu JadoTu closed this Jun 13, 2026
@JadoTu

JadoTu commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator Author

Close this PR as it is contained in #15331.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant