[https://nvbugs/6293712][fix] Patch GSM8K.EVALUATE_KWARGS with scores_filter="exact_match,strict-match"…#15346
Open
tensorrt-cicd wants to merge 1 commit into
Open
Conversation
…atch only Nano V3 is a chain-of-thought reasoning model. lm-eval's flexible-extract regex picks the last numeric span in the response (group_select=-1), which on Nano V3 frequently lands on an intermediate calculation in the long reasoning chain rather than the canonical '#### N' final-answer marker. Strict-match correctly extracts the final answer. In the failing GB300 (SM103) NVFP4 1-GPU run, GSM8K strict-match was 75.13 (above the 65.428 reference) but flexible-extract was 44.66, dragging the mean to 59.89 and below the 62.225 threshold even though the model itself is producing high-quality answers. MMLU passes the same run with margin. Mirror the existing pattern in the same file (TestGptOssBase.test_mxfp4_gsm8k, line 1283) and across test_llm_api_pytorch.py: patch GSM8K.EVALUATE_KWARGS to set scores_filter='exact_match,strict-match', so the GSM8K score uses the authoritative CoT filter only. Reference accuracy and threshold are unchanged. Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesNemotronNanoV3 GSM8K scoring override
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Links
Summary by CodeRabbit
Tests